spacewander commented on a change in pull request #3204:
URL: https://github.com/apache/apisix/pull/3204#discussion_r552480307
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -26,6 +26,12 @@ worker_processes {* worker_processes *};
worker_cpu_affinity auto;
{% end %}
+# main start configuration snippet starts
Review comment:
I think we can directly move `main_configuration_snippet` here instead
of creating new one?
##########
File path: .travis/apisix_cli_test/test_main.sh
##########
@@ -675,6 +677,8 @@ nginx_config:
set $my "var";
http_admin_configuration_snippet: |
log_format admin "$request_time $pipe";
+ http_end_configuration_snippet: |
Review comment:
Need to check `http_end_configuration_snippet` like other snippet in the
test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
