spacewander commented on a change in pull request #3204:
URL: https://github.com/apache/apisix/pull/3204#discussion_r552488750
##########
File path: .travis/apisix_cli_test/test_main.sh
##########
@@ -705,6 +707,12 @@ if [ ! $? -eq 0 ]; then
exit 1
fi
+grep 'server_names_hash_bucket_size 128;' -A 2 conf/nginx.conf | grep
"configuration snippet ends" > /dev/null
Review comment:
Would be better if we also check there is a '}' in the output, like:
grep 'server_names_hash_bucket_size 128;' -A 3 conf/nginx.conf | grep "}" >
/dev/null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
