imjoey opened a new pull request #1250: URL: https://github.com/apache/apisix-dashboard/pull/1250
Signed-off-by: imjoey <[email protected]> Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues Fixes #1246 . ___ Changes proposed in this PR: 1. Change the name of `UnexpectedBody` property to `UnexpectBody` to get along with `ExpectBody` field; 2. Set the types of `ExpectBody` and `UnexpectBody ` to `interface{}`, to add support for checking on multiple strings. See #1246 for details. Also use this new feature to refactor the test case of `server_info_test.go` to reduce time cost; 3. Fix a logical bug. Previously, if the `ExpectBody` is set as `""`, the check will be certainly ignored. While actually I believe this purpose is to expect the body be empty. Please see https://github.com/apache/apisix-dashboard/blob/93b9765e3e77c6cefe0487e1657886d5f05d4146/api/test/e2e/route_with_plugin_cors_test.go#L138-L153 as an example; 4. Other minor style fixes; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
