starsz commented on a change in pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#discussion_r554656529
##########
File path: api/test/e2e/server_info_test.go
##########
@@ -121,25 +112,14 @@ func TestServerInfo_Get_OmitEmptyValue(t *testing.T) {
func TestServerInfo_List_OmitEmptyValue(t *testing.T) {
testCases := []HttpTestCase{
{
- Desc: "list all server info",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization":
token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"create_time\":",
- },
- {
- Desc: "list server info with hostname",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Query: "hostname=apisix_",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization":
token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"update_time\":",
Review comment:
Hi, why delete this test?
This test is for `list server info with hostname`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
