spacewander commented on a change in pull request #3278:
URL: https://github.com/apache/apisix/pull/3278#discussion_r557052944
##########
File path: apisix/balancer/chash.lua
##########
@@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream)
chash_key = ctx.var["http_" .. key]
elseif hash_on == "cookie" then
chash_key = ctx.var["cookie_" .. key]
+ elseif hash_on == "vars_combinations" then
+ chash_key = core.utils.resolve_var(key, ctx.var);
+ core.log.info("vars_combinations: " .. chash_key)
Review comment:
The error check is needed. But the test case can be omitted. Since there
is no backtrack in the regex which used to match variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
