spacewander commented on a change in pull request #3278:
URL: https://github.com/apache/apisix/pull/3278#discussion_r557291411



##########
File path: apisix/admin/upstreams.lua
##########
@@ -45,6 +45,10 @@ local function get_chash_key_schema(hash_on)
         return nil, nil
     end
 
+    if hash_on == "vars_combinations" then

Review comment:
       I think `vars_combinations` is good enough for ordinary people. `complex 
value` looks like the opposite of `simple value`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to