jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r559701144
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -146,6 +146,9 @@ http {
lua_shared_dict jwks 1m; # cache for JWKs
lua_shared_dict introspection 10m; # cache for JWT verification
results
+ # for authz-keycloak
+ lua_shared_dict access_tokens 1m; # cache for service account
access tokens
Review comment:
@spacewander Quick question: We also need a shared dict for the
discovery documents. I have added that to `apisix/t/APISIX.pm` now as well. But
I can't see other dicts that e.g. the `openid-connect` plugin needs in that
file. How do the tests then run successfully w/o the dict definitions?
##########
File path: apisix/plugins/authz-keycloak.lua
##########
@@ -53,10 +54,24 @@ local schema = {
keepalive_timeout = {type = "integer", minimum = 1000, default =
60000},
keepalive_pool = {type = "integer", minimum = 1, default = 5},
ssl_verify = {type = "boolean", default = true},
+ client_id = {type = "string", minLength = 1, maxLength = 100},
+ client_secret = {type = "string", minLength = 1, maxLength = 100},
+ lazy_load_paths = {type = "boolean", default = false},
+ http_method_as_scope = {type = "boolean", default = false},
},
+ required = {"client_id"},
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
