jenskeiner commented on pull request #3308: URL: https://github.com/apache/apisix/pull/3308#issuecomment-762373784
I reckon the new tests added are sufficient to check the basic validity of the updated schema wrt. to (conditionally) required attributes like `resource_registration_endpoint`. However, it would make sense to add more cases to test the actual functionality of `lazy_load_paths` and `http_method_as_scope`. The problem is that this would very likely require some modifications to the Keycloak container image since we need resources linked to scopes that correspond to HTTP method names. Also would probably need to verify resource definitions' URI settings so we can test the resource resolution via the resource registration endpoint. Feedback? The Docker image is in @sshniro's private repo. Can you advise @sshniro how we should go about making modifications? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
