juzhiyuan commented on a change in pull request #1376:
URL: https://github.com/apache/apisix-dashboard/pull/1376#discussion_r564297945
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -17,10 +17,23 @@
/* eslint-disable no-undef */
context('settings page smoke test', () => {
- const domSelectors = {
+ const data = {
+ grafana_address: 'Grafana Address',
+ grafana_explain1: 'Grafana address should begin with HTTP or HTTPS',
Review comment:
`should start with xx`
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -17,10 +17,23 @@
/* eslint-disable no-undef */
context('settings page smoke test', () => {
- const domSelectors = {
+ const data = {
+ grafana_address: 'Grafana Address',
+ grafana_explain1: 'Grafana address should begin with HTTP or HTTPS',
+ grafana_explain2: 'Address is illegality',
+ update_success: 'Update Configuration Successfully',
Review comment:
`Update Successfully`
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -17,10 +17,23 @@
/* eslint-disable no-undef */
context('settings page smoke test', () => {
- const domSelectors = {
+ const data = {
+ grafana_address: 'Grafana Address',
+ grafana_explain1: 'Grafana address should begin with HTTP or HTTPS',
+ grafana_explain2: 'Address is illegality',
Review comment:
`Invalid URL`
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -17,10 +17,23 @@
/* eslint-disable no-undef */
context('settings page smoke test', () => {
- const domSelectors = {
+ const data = {
+ grafana_address: 'Grafana Address',
+ grafana_explain1: 'Grafana address should begin with HTTP or HTTPS',
+ grafana_explain2: 'Address is illegality',
+ update_success: 'Update Configuration Successfully',
+ url1: 'httx://www.test.com',
Review comment:
Use `invalidURL` would be more reasonable.
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -17,10 +17,23 @@
/* eslint-disable no-undef */
context('settings page smoke test', () => {
- const domSelectors = {
+ const data = {
+ grafana_address: 'Grafana Address',
+ grafana_explain1: 'Grafana address should begin with HTTP or HTTPS',
Review comment:
`explanation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
