juzhiyuan commented on a change in pull request #1376:
URL: https://github.com/apache/apisix-dashboard/pull/1376#discussion_r564523149
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -18,20 +18,20 @@
context('settings page smoke test', () => {
const data = {
- grafana_address: 'Grafana Address',
- start_explanation: 'Grafana address should begin with HTTP or HTTPS',
- after_explanation: 'Address is illegality',
- update_successfully: 'Update Configuration Successfully',
- invalid_URL: 'httx://www.test.com',
- new_URL: 'https://apisix.apache.org/',
- fetch_URL: 'fetchURL',
+ grafanaAddress: 'Grafana Address',
+ grafanaExplain1: 'Grafana address should begin with HTTP or HTTPS',
+ grafanaExplain2: 'Address is illegality',
Review comment:
`Explain` is a variable, use `explanation`.
##########
File path: web/cypress/integration/settings/settings-smoketest.spec.js
##########
@@ -18,20 +18,20 @@
context('settings page smoke test', () => {
const data = {
- grafana_address: 'Grafana Address',
- start_explanation: 'Grafana address should begin with HTTP or HTTPS',
- after_explanation: 'Address is illegality',
- update_successfully: 'Update Configuration Successfully',
- invalid_URL: 'httx://www.test.com',
- new_URL: 'https://apisix.apache.org/',
- fetch_URL: 'fetchURL',
+ grafanaAddress: 'Grafana Address',
+ grafanaExplain1: 'Grafana address should begin with HTTP or HTTPS',
+ grafanaExplain2: 'Address is illegality',
+ updateSuccessfully: 'Update Configuration Successfully',
+ invalidURL: 'httx://www.test.com',
+ ValidURL: 'https://apisix.apache.org/',
Review comment:
```suggestion
validURL: 'https://apisix.apache.org/',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
