Junnplus commented on a change in pull request #213:
URL:
https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564980836
##########
File path: charts/apisix-ingress-controller/templates/rbac.yaml
##########
@@ -157,5 +153,6 @@ roleRef:
name: {{ .Release.Name }}-clusterrole
subjects:
- kind: ServiceAccount
- name: {{ .Release.Name }}-serviceaccount
+ name: {{ include "apisix-ingress-controller.serviceAccountName" . }}
Review comment:
I don't think so, service account may not be created, user can use
existd name.
see [best practices for
RBAC](https://helm.sh/docs/chart_best_practices/rbac/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
