Junnplus commented on a change in pull request #213:
URL:
https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564990948
##########
File path: charts/apisix-ingress-controller/templates/rbac.yaml
##########
@@ -14,11 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-apiVersion: v1
-kind: ServiceAccount
-metadata:
- name: {{ .Release.Name }}-serviceaccount
----
+{{- if .Values.rbac.create }}
Review comment:
`{{-` is right, `{{` will keep a blank line.
```
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
