tokers commented on a change in pull request #215:
URL:
https://github.com/apache/apisix-ingress-controller/pull/215#discussion_r565838987
##########
File path: pkg/ingress/controller/controller.go
##########
@@ -64,7 +64,8 @@ type Controller struct {
crdController *Api6Controller
crdInformerFactory externalversions.SharedInformerFactory
- endpointsController *endpointsController
+ endpointsController *endpointsController
Review comment:
Well, i think an extra abstraction (interface) can be used to shield the
real type of Endpoints (Endpoints or EndpointSlices).
##########
File path: cmd/ingress/ingress.go
##########
@@ -123,6 +123,7 @@ the apisix cluster and others are created`,
cmd.PersistentFlags().StringVar(&cfg.LogOutput, "log-output", "stderr",
"error log output file")
cmd.PersistentFlags().StringVar(&cfg.HTTPListen, "http-listen",
":8080", "the HTTP Server listen address")
cmd.PersistentFlags().BoolVar(&cfg.EnableProfiling, "enable-profiling",
true, "enable profiling via web interface host:port/debug/pprof")
+ cmd.PersistentFlags().BoolVar(&cfg.EnableEndpointSlice,
"enable-endpointslice", false, "enable endpointSlice resource support")
Review comment:
I prefer the way that istio uses, which introduces an option like
`endpoint-mode`, value can be "endpointsOnly", "endpointsliceOnly".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
