lianghao208 commented on pull request #215: URL: https://github.com/apache/apisix-ingress-controller/pull/215#issuecomment-768995616
@tokers I think in istio, they use bool type `EnableEndpointSliceController` from env params when running the controller: [https://github.com/istio/istio/blob/f41b17563d0ae00a99694cb1a73e329c4a09ff3d/pilot/pkg/features/pilot.go#L224-#L230](https://github.com/istio/istio/blob/f41b17563d0ae00a99694cb1a73e329c4a09ff3d/pilot/pkg/features/pilot.go#L224-#L230) and then convert it into struct `Option` with string "endpointsOnly" or "endpointsliceOnly". But apisix ingress controller import read configuration from file or configMap, wouldn't it be redundant if using string like "endpointsOnly" or "endpointsliceOnly" in configuration file? any suggestions? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
