Yiyiyimu commented on a change in pull request #3457: URL: https://github.com/apache/apisix/pull/3457#discussion_r567437290
########## File path: doc/plugins/prometheus.md ########## @@ -120,6 +120,10 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719)  + Review comment: There are currently two problems for histogram: 1. The legends have leading for trailing zeros ([reason](https://github.com/knyar/nginx-lua-prometheus/blob/499de49cab0217c855dd9be12c3c1596cc2e9827/prometheus.lua#L24-L27)) so it looks messy 2. There are two many buckets out there. We don't need buckets like "30,40,50,60,70,80,90,100,200,300,400,500". After reduce buckets, it somewhat looks better  Or we could use 95-percentile as @tokers said. I'm not so familiar with monitor APISIX, so what do you think about that ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
