Yiyiyimu commented on a change in pull request #3457:
URL: https://github.com/apache/apisix/pull/3457#discussion_r567438754



##########
File path: doc/plugins/prometheus.md
##########
@@ -120,6 +120,10 @@ Or you can goto [Grafana 
official](https://grafana.com/grafana/dashboards/11719)
 
 ![](../../doc/images/plugin/grafana_3.png)
 
+![](../../doc/images/plugin/grafana_4.png)

Review comment:
       For `etcd-reachable` and `nginx metric errors`, the comments of what 
these two metrics do are explained on the metrics page alongside with the data. 
And for how I implement it
   - `etcd-reachable`: when etcd is reachable, the metric would be 1 and the 
graph would be green. While it is disconnected, the metric turns to 0 and the 
panel would be red.
   - `nginx metric errors`: it measures how many errors of 
nginx-lua-prometheus. I also leave it to only show the current error number 
without time series, since if it is larger than 0, it should be taken care of. 
And also if it is larger than 0, it would turn red.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to