spacewander commented on a change in pull request #3472:
URL: https://github.com/apache/apisix/pull/3472#discussion_r568301053



##########
File path: Makefile
##########
@@ -55,7 +55,9 @@ help: default
 .PHONY: deps
 deps: default
 ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luarocks)", "")

Review comment:
       What about:
   ```diff
    deps: default
    ifeq ($(LUAROCKS_VER),luarocks 3.)
           mkdir ~/.luarocks || true
   -       luarocks config variables.OPENSSL_LIBDIR $(addprefix $(OR_PREFIX), 
openssl/lib)
   +       luarocks config --local variables.OPENSSL_LIBDIR $(addprefix 
$(OR_PREFIX), openssl/lib)
           luarocks config variables.OPENSSL_INCDIR $(addprefix $(OR_PREFIX), 
openssl/include)
           luarocks install rockspec/apisix-master-0.rockspec --tree=deps 
--only-deps --local
    else
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to