Yiyiyimu commented on a change in pull request #3472:
URL: https://github.com/apache/apisix/pull/3472#discussion_r568295463
##########
File path: Makefile
##########
@@ -55,7 +55,9 @@ help: default
.PHONY: deps
deps: default
ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luarocks)", "")
Review comment:
Yeah that would be better! Thanks!
And I made a mistake yesterday. No matter how we install luarocks, the
config would always write to `/usr/local/etc/luarocks`, so we all need sudo
permission. Is that the same on your side?
##########
File path: Makefile
##########
@@ -55,7 +55,9 @@ help: default
.PHONY: deps
deps: default
ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luarocks)", "")
Review comment:
It's weird... I installed lua5.3 and configure luarocks to it this
morning to do some stuff, and found out it changes some config that even
though I re-configure luarocks to luajit from openresty, it still tries to find
lua5.3.
So I remove everything about luarocks, and re-install it with the script.
Now this time, it would write config to `~/.luarocks` without the `--local`
flag.
I'm not so sure right now. If you could not reproduce this problem, I'll
close it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
