fukiki commented on a change in pull request #125:
URL: https://github.com/apache/apisix-docker/pull/125#discussion_r568532977
##########
File path: all-in-one/apisix-dashboard/Dockerfile
##########
@@ -23,8 +23,7 @@ RUN set -x \
&& luarocks config variables.OPENSSL_INCDIR
/usr/local/openresty/openssl/include \
Review comment:
`&& mkdir ~/.luarocks \` should also be added before `luarocks config`
in this file, otherwise, push ci will be failed.
##########
File path: all-in-one/apisix/Dockerfile
##########
@@ -23,8 +23,7 @@ RUN set -x \
&& luarocks config variables.OPENSSL_INCDIR
/usr/local/openresty/openssl/include \
Review comment:
&& mkdir ~/.luarocks \ should also be added before luarocks config in
this file, otherwise, push ci will be failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
