juzhiyuan commented on a change in pull request #1432:
URL: https://github.com/apache/apisix-dashboard/pull/1432#discussion_r570665024
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
Review comment:
Do you mean `disabledSwitcher`?
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
Review comment:
Do you mean `upstreamSelector?`
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
Review comment:
Do you mean `serviceSelector`?
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
Review comment:
```suggestion
"deleteButton": ".ant-btn-dangerous",
```
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
Review comment:
Do you mean `nameSelector`?
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
Review comment:
```suggestion
"pluginCard": ".ant-card",
```
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
+ "fileTypeRadio": "[type=radio]",
+
+ "uriInput": "#debugUri",
+
+ "hosts_0": "#hosts_0",
+ "labels_0_labelKey": "#labels_0_labelKey",
+ "labels_0_labelValue": "#labels_0_labelValue",
+ "searchName": "[title=Name]",
+ "searchLabels": "[title=Labels]",
+
+ "pageContainer": ".ant-pro-page-container",
+ "notificationMsg": ".ant-notification-notice-message",
Review comment:
`notificationMessage`
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
+ "fileTypeRadio": "[type=radio]",
+
+ "uriInput": "#debugUri",
+
+ "hosts_0": "#hosts_0",
+ "labels_0_labelKey": "#labels_0_labelKey",
+ "labels_0_labelValue": "#labels_0_labelValue",
+ "searchName": "[title=Name]",
+ "searchLabels": "[title=Labels]",
+
+ "pageContainer": ".ant-pro-page-container",
+ "notificationMsg": ".ant-notification-notice-message",
+ "setting": ".ant-space-align-center",
+ "grafanaURL": "#grafanaURL",
+ "explain": ".ant-form-item-explain",
+
+ "selectItem": ".ant-select-item-option-content"
Review comment:
have a better name?
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
+ "fileTypeRadio": "[type=radio]",
+
+ "uriInput": "#debugUri",
Review comment:
should have a good name
##########
File path: web/cypress/integration/route/create-edit-delete-route.spec.js
##########
@@ -22,8 +22,9 @@ context('Create and Delete Route', () => {
const sleepTime = 100;
beforeEach(() => {
- // init login
cy.login();
+
+ cy.fixture('selector.json').as('domSelector');
Review comment:
Not done?
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
+ "fileTypeRadio": "[type=radio]",
+
+ "uriInput": "#debugUri",
+
+ "hosts_0": "#hosts_0",
+ "labels_0_labelKey": "#labels_0_labelKey",
+ "labels_0_labelValue": "#labels_0_labelValue",
+ "searchName": "[title=Name]",
+ "searchLabels": "[title=Labels]",
Review comment:
ditto
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
+ "fileTypeRadio": "[type=radio]",
+
+ "uriInput": "#debugUri",
+
+ "hosts_0": "#hosts_0",
+ "labels_0_labelKey": "#labels_0_labelKey",
+ "labels_0_labelValue": "#labels_0_labelValue",
+ "searchName": "[title=Name]",
+ "searchLabels": "[title=Labels]",
+
+ "pageContainer": ".ant-pro-page-container",
+ "notificationMsg": ".ant-notification-notice-message",
+ "setting": ".ant-space-align-center",
Review comment:
Name & Value don't have a relation IMO
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
Review comment:
Should be the same as other `upstreamSelector`
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
Review comment:
Do you mean `nameSelector`?
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
+ "fileTypeRadio": "[type=radio]",
+
+ "uriInput": "#debugUri",
+
+ "hosts_0": "#hosts_0",
+ "labels_0_labelKey": "#labels_0_labelKey",
+ "labels_0_labelValue": "#labels_0_labelValue",
+ "searchName": "[title=Name]",
Review comment:
ditto
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -1,7 +1,49 @@
{
+ "switcher": ".ant-space-align-center",
"dropdown": ".rc-virtual-list",
"notification": ".ant-notification-notice-message",
"drawerBody": ".ant-drawer-wrapper-body",
"notificationCloseIcon": ".ant-notification-close-icon",
- "notificationDesc": ".ant-notification-notice-description"
+ "notificationDesc": ".ant-notification-notice-description",
+
+ "pluginsCard": ".ant-card",
+ "pageContent": ".ant-pro-page-container",
+
+ "tableCell": ".ant-table-cell",
+ "empty": ".ant-empty-normal",
+ "refresh": ".anticon-reload",
+ "codemirror": ".CodeMirror",
+ "switch": "#disable",
+ "deleteBtn": ".ant-btn-dangerous",
+
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "upstream_id": "#upstream_id",
+ "input": ":input",
+ "custom_upstream": "[title=Custom]",
+ "title_name": "[title=Name]",
+ "test_service": "[title=test_service]",
+
+ "description": "#desc",
+ "search_name": "[title=Name]",
+ "upstream_selector": "[data-cy=upstream_selector]",
+
+ "file": "[type=file]",
Review comment:
should be more detailed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
