guoqqqi commented on pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#issuecomment-773830951
> This PR looks good to me, but I have a question to confirm, if a selector is not public, should we extract a variable in that case? @guoqqqi I think we'd better put all the variables in the public file, not only to keep the formatting consistent, but we may use any of them later, what do you think？ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
