tokers commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571822562
##########
File path: apisix/cli/ops.lua
##########
@@ -238,9 +238,19 @@ Please modify "admin_key" in conf/config.yaml .
util.die("missing apisix.proxy_cache for plugin proxy-cache\n")
end
- --support multiple ports listen, compatible with the original style
+ -- support multiple ports listen, compatible with the original style
if type(yaml_conf.apisix.node_listen) == "number" then
- local node_listen = {yaml_conf.apisix.node_listen}
+ local node_listen = {{port = yaml_conf.apisix.node_listen}}
+ yaml_conf.apisix.node_listen = node_listen
+ elseif type(yaml_conf.apisix.node_listen) == "table" then
+ local node_listen = {}
+ for index, value in ipairs(yaml_conf.apisix.node_listen) do
+ if type(value) == "number" then
Review comment:
Is the number type really needed? I think the following way is enough.
```yaml
node_listen:
- port: 9080
- port: 9180
enable_http2: true
```
##########
File path: doc/grpc-proxy.md
##########
@@ -37,6 +37,7 @@ Here's an example, to proxying gRPC service by specified
route:
* attention: the `scheme` of the route's upstream must be `grpc` or `grpcs`.
* attention: APISIX use TLS‑encrypted HTTP/2 to expose gRPC service, so need
to [config SSL certificate](https.md)
+* attention: APISIX also support to expose gRPC service with plaintext HTTP/2,
which do not need to config SSL certificate, usually used to proxy gRPC service
in intranet environment
Review comment:
which do not need to config SSL certificate => which doesn't rely on
ALPN/NPN extensions in TLS/SSL protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
