spacewander commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571882122
##########
File path: apisix/cli/ops.lua
##########
@@ -238,9 +238,19 @@ Please modify "admin_key" in conf/config.yaml .
util.die("missing apisix.proxy_cache for plugin proxy-cache\n")
end
- --support multiple ports listen, compatible with the original style
+ -- support multiple ports listen, compatible with the original style
if type(yaml_conf.apisix.node_listen) == "number" then
- local node_listen = {yaml_conf.apisix.node_listen}
+ local node_listen = {{port = yaml_conf.apisix.node_listen}}
+ yaml_conf.apisix.node_listen = node_listen
+ elseif type(yaml_conf.apisix.node_listen) == "table" then
+ local node_listen = {}
+ for index, value in ipairs(yaml_conf.apisix.node_listen) do
+ if type(value) == "number" then
Review comment:
We need to be backward compatibility unless it is a bugfix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
