tokers commented on a change in pull request #337:
URL:
https://github.com/apache/apisix-ingress-controller/pull/337#discussion_r606607639
##########
File path: test/e2e/ingress/secret.go
##########
@@ -144,6 +144,6 @@
RU+QPRECgYB6XW24EI5+w3STbpnc6VoTS+sy9I9abTJPYo9LpCJwfMYc9Tg9Cx2K
tlsUpdate, err := s.ListApisixTls()
assert.Nil(ginkgo.GinkgoT(), err, "list tlsUpdate error")
assert.Len(ginkgo.GinkgoT(), tlsUpdate, 1, "tls number not
expect")
- assert.NotEqual(ginkgo.GinkgoT(), KeyInApisix,
tlsUpdate[0].Key, "tls key not expect")
+ assert.Equal(ginkgo.GinkgoT(), certUpdate, tlsUpdate[0].Cert,
"tls cert not expect")
Review comment:
Both the cert and key should be checked.
##########
File path: test/e2e/ingress/secret.go
##########
@@ -144,6 +144,6 @@
RU+QPRECgYB6XW24EI5+w3STbpnc6VoTS+sy9I9abTJPYo9LpCJwfMYc9Tg9Cx2K
tlsUpdate, err := s.ListApisixTls()
assert.Nil(ginkgo.GinkgoT(), err, "list tlsUpdate error")
assert.Len(ginkgo.GinkgoT(), tlsUpdate, 1, "tls number not
expect")
- assert.NotEqual(ginkgo.GinkgoT(), KeyInApisix,
tlsUpdate[0].Key, "tls key not expect")
+ assert.Equal(ginkgo.GinkgoT(), certUpdate, tlsUpdate[0].Cert,
"tls cert not expect")
Review comment:
We may also add some test cases to cover the ApisixTls delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
