tokers commented on a change in pull request #337:
URL:
https://github.com/apache/apisix-ingress-controller/pull/337#discussion_r610995607
##########
File path: test/e2e/ingress/secret.go
##########
@@ -89,61 +159,129 @@ wrw7im4TNSAdwVX4Y1F4svJ2as5SJn5QYGAzXDixNuwzXYrpP9rzA2s=
tls, err := s.ListApisixTls()
assert.Nil(ginkgo.GinkgoT(), err, "list tls error")
assert.Len(ginkgo.GinkgoT(), tls, 1, "tls number not expect")
+ assert.Equal(ginkgo.GinkgoT(), cert, tls[0].Cert, "tls cert not
expect")
+ assert.Equal(ginkgo.GinkgoT(), key_compare, tls[0].Key, "tls
key not expect")
+
+ // check DP
+ s.NewAPISIXHttpsClient(host).GET("/ip").WithHeader("Host",
host).Expect().Status(http.StatusOK).Body().Raw()
+
+ dialer := &net.Dialer{
+ Timeout: 30 * time.Second,
+ KeepAlive: 30 * time.Second,
+ DualStack: true,
+ }
+
+ http.DefaultTransport.(*http.Transport).DialContext = func(ctx
context.Context, network, addr string) (net.Conn, error) {
Review comment:
I think `DialContext` can also be removed if we already have the correct
`ServerName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
