imjoey commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606742998
########## File path: docs/en/latest/USER_GUIDE.md ########## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: > I think CDN gives us more ease to handle @iamayushdas agreed +1 on Github CDN. Actually I'm not sure that is there any possibility for the images be unavailable to the pages. For example, the Github account which uploaded the images is deleted, or any other reasons. It's ok for me if the URLs of images will be never changed or inaccessible. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
