imjoey commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606747752
########## File path: docs/en/latest/USER_GUIDE.md ########## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: > No, there wont be a problem because its under the github server and deleting the account won't create any isse. > > Now if your are fine with this PR you can give a approval to it :smiley: @imjoey @iamayushdas Sure, very glad to know it will always work. Thanks for clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
