gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r616277264
##########
File path: pkg/ingress/apisix_tls.go
##########
@@ -117,6 +123,8 @@ func (c *apisixTlsController) sync(ctx context.Context, ev
*types.Event) error {
zap.Error(err),
zap.Any("ApisixTls", tls),
)
+ message := fmt.Sprintf(MessageResourceFailed, TlsController,
err.Error())
+ c.recorder.Event(tls, corev1.EventTypeWarning, FailedSynced,
message)
Review comment:
Will need to query resource objects repeatedly if in `c.handleSyncErr `,
which is processed in method sync()
##########
File path: pkg/ingress/apisix_upstream.go
##########
@@ -122,6 +128,8 @@ func (c *apisixUpstreamController) sync(ctx
context.Context, ev *types.Event) er
svc, err := c.controller.svcLister.Services(namespace).Get(name)
if err != nil {
log.Errorf("failed to get service %s: %s", key, err)
+ message := fmt.Sprintf(MessageResourceFailed,
UpstreamController, err.Error())
Review comment:
Will need to query resource objects repeatedly if in `c.handleSyncErr `,
which is processed in method sync()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
