gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r616278503
##########
File path: pkg/ingress/apisix_route.go
##########
@@ -198,14 +210,50 @@ func (c *apisixRouteController) sync(ctx context.Context,
ev *types.Event) error
}
func (c *apisixRouteController) handleSyncErr(obj interface{}, err error) {
+ event := obj.(*types.Event)
+ route := event.Object.(kube.ApisixRouteEvent).OldObject
+ // conditions
+ condition := metav1.Condition{
+ Type: "APISIXSynced",
+ }
if err == nil {
+ message := fmt.Sprintf(MessageResourceSynced, RouteController)
+ if route.GroupVersion() == kube.ApisixRouteV1 {
+ c.recorder.Event(route.V1(), v1.EventTypeNormal,
SuccessSynced, message)
+ } else if route.GroupVersion() == kube.ApisixRouteV2alpha1 {
+ c.recorder.Event(route.V2alpha1(), v1.EventTypeNormal,
SuccessSynced, message)
+ // build condition
+ condition.Reason = "SyncSuccessfully"
+ condition.Status = "True"
+ condition.Message = "Sync Successfully"
+ // set to status
+ routev2 := route.V2alpha1()
+ meta.SetStatusCondition(routev2.Status.Conditions,
condition)
+
v2alpha1.New(kube.GetApisixClient().ApisixV2alpha1().RESTClient()).ApisixRoutes(routev2.Namespace).
+ Update(context.TODO(), routev2, nil)
+ }
c.workqueue.Forget(obj)
return
}
log.Warnw("sync ApisixRoute failed, will retry",
zap.Any("object", obj),
zap.Error(err),
)
+ message := fmt.Sprintf(MessageResourceFailed, RouteController,
err.Error())
+ if route.GroupVersion() == kube.ApisixRouteV1 {
+ c.recorder.Event(route.V1(), v1.EventTypeWarning, FailedSynced,
message)
+ } else if route.GroupVersion() == kube.ApisixRouteV2alpha1 {
+ c.recorder.Event(route.V2alpha1(), v1.EventTypeWarning,
FailedSynced, message)
+ // build condition
+ condition.Reason = "SyncFailed"
+ condition.Status = "False"
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
