bisakhmondal commented on a change in pull request #1788:
URL: https://github.com/apache/apisix-dashboard/pull/1788#discussion_r634517991
##########
File path: api/internal/utils/pid.go
##########
@@ -30,16 +30,14 @@ func WritePID(filepath string) error {
return fmt.Errorf("instance of Manager API already running: a
pid file exists in %s", filepath)
}
pid := os.Getpid()
- f, err := os.OpenFile(filepath,
os.O_WRONLY|os.O_CREATE|os.O_TRUNC|os.O_CREATE, 0600)
+ f, err := os.OpenFile(filepath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC,
0600)
Review comment:
Hi, actually the `O_CREATE` flag had multiple occurrences :)
##########
File path: api/build.sh
##########
@@ -22,6 +22,9 @@ GITHASH=$(cat ./.githash 2> /dev/null || HASH="ref: HEAD";
while [[ $HASH == ref
GOLDFLAGS="-X github.com/apisix/manager-api/internal/utils.version=${VERSION}
-X github.com/apisix/manager-api/internal/utils.gitHash=${GITHASH}"
+# Ensuring clean state
+# rm -rf api/cmd/dag-to-lua && git checkout api/cmd/dag-to-lua
Review comment:
Yeah sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
