bisakhmondal commented on a change in pull request #1788:
URL: https://github.com/apache/apisix-dashboard/pull/1788#discussion_r637042871
##########
File path: api/cmd/html/index.html
##########
@@ -0,0 +1,36 @@
+<!--
Review comment:
Oh, actually I thought for every build, you wish to build HTML
> We cannot embed old files, but files built from the current source.
Yes the current code also ensures that
too[ref](https://github.com/apache/apisix-dashboard/pull/1788/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R46-R49)
` rm -rf api/cmd/html && git checkout api/cmd/html/ && api/build.sh &&
mkdir -p output/logs`
The `rm -rf` and `checkout` is helpful because I have excluded all build
files except `index.html` from the HTML dir.
To be honest, the static index.html serves two purpose
1. preventing the error from go embed the empty directory.
2. Instead of filling the directory with some garbage file, an HTML with a
message seems reasonable. As anyways it will get replaced by web build's
index.html.
Let me know what changes should I make
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
