wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847576227


   > My opinion:
   > 
   > 1. normal response: keep the current behavior
   > 2. without response (the timed out case pointed by @yxudong): add `finish` 
call if we haven't called it yet
   > 3. header only response (`HEAD` request, 204 or 304 response): add 
`finish` call in the header filter phase.
   
   @yxudong Would you work on a patch to SkyWalking nginx agent to do that? We 
need some code changes rather than only doc change.
   
   cc @dmsolr I think after this, we need to adjust Kong plugin. @spacewander 
we need to adopt this fix in APISIX too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to