spacewander commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847909777


   > In addition, sw_tracer:finish should be called in header_filter_by_lua 
phase logically, because header_filter_by_lua phase is before 
body_filter_by_lua phase.
   
   Calling the `finish` in header_filter_by_lua in a non-head-only response 
will result in a too-short trace span. Consider the server is serving a 1 GB 
file, the time when the response finish generating header is quite earlier than 
generating all the body.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to