gxthrj commented on a change in pull request #507:
URL:
https://github.com/apache/apisix-ingress-controller/pull/507#discussion_r642768561
##########
File path: pkg/types/pod.go
##########
@@ -54,22 +55,24 @@ func NewPodCache() PodCache {
}
func (p *podCache) Add(pod *corev1.Pod) error {
- if pod.Status.Phase != corev1.PodRunning {
- return ErrPodNotRunning
+ ip := pod.Status.PodIP
Review comment:
Pod assigned ip does not mean that it is directly available. If the pod
is not in the ready state, it will cause traffic to fail. The logic of health
check is required, or the judgment is combined with the endpoint controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
