tokers commented on a change in pull request #507:
URL:
https://github.com/apache/apisix-ingress-controller/pull/507#discussion_r642864515
##########
File path: pkg/types/pod.go
##########
@@ -54,22 +55,24 @@ func NewPodCache() PodCache {
}
func (p *podCache) Add(pod *corev1.Pod) error {
- if pod.Status.Phase != corev1.PodRunning {
- return ErrPodNotRunning
+ ip := pod.Status.PodIP
Review comment:
It's not the responsibility of `podCache` to do it, also, it doesn't
matter as we only use endpoints subset in the ready part of an Endpoints
resource. So unready pod won't be referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
