tao12345666333 commented on pull request #529:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/529#issuecomment-854899222


   ApisixConsumer's e2e test failed because it triggered the max length limit 
of consumer name in APISIX. Current limit is 32 
   
https://github.com/apache/apisix/blob/10677e9067b43fb3b2555c917c322b4454b22c77/apisix/schema_def.lua#L623
   
   We have two solutions
   
   1. Increase the limit on the length of APISIX consumer name. 
https://github.com/apache/apisix/blob/10677e9067b43fb3b2555c917c322b4454b22c77/apisix/schema_def.lua#L623
   
   2. Shorten the namespace name generated by the current e2e test 
https://github.com/apache/apisix-ingress-controller/blob/2bf4b6be29648c1c3e98006edae50252a0555a08/test/e2e/scaffold/scaffold.go#L262
   
   I tried to create ApisixConsumer in other namespaces, but ApisixIngress 
currently only monitors the namespace where it is located. A third solution can 
be derived here, which is to update deployment in this testcase.
   
   But I think the second method has the lowest cost.
   
   cd @tokers @gxthrj  @membphis 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to