tao12345666333 commented on a change in pull request #529:
URL:
https://github.com/apache/apisix-ingress-controller/pull/529#discussion_r646474230
##########
File path: pkg/types/apisix/v1/types.go
##########
@@ -455,7 +456,8 @@ func ComposeConsumerName(namespace, name string) string {
p := make([]byte, 0, len(namespace)+len(name)+1)
buf := bytes.NewBuffer(p)
- buf.WriteString(namespace)
+ // TODO If APISIX modifies the consumer name schema, we can drop this.
+ buf.WriteString(strings.Replace(namespace, "-", "_", -1))
Review comment:
change to lower priority.
Priority to maintain compatibility with APISIX v2.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
