gxthrj commented on a change in pull request #106:
URL: https://github.com/apache/apisix-helm-chart/pull/106#discussion_r658397488
##########
File path: charts/apisix/values.yaml
##########
@@ -211,12 +211,21 @@ etcd:
service:
port: 2379
- replicaCount: 3
+ statefulset:
+ replicaCount: 3
+ persistence:
+ enabled: true
+ size: 8Gi
+ # storageClass: "-"
dashboard:
enabled: false
-
+ config:
Review comment:
If we add field in values, Please show us where it will be used.
I think we can not add dashboard configuration here, but should add it into
`chars/apsix-dashboard/values.yaml`.
cc @tao12345666333 Am I right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
