caryyu commented on a change in pull request #106:
URL: https://github.com/apache/apisix-helm-chart/pull/106#discussion_r658413021
##########
File path: charts/apisix/values.yaml
##########
@@ -211,12 +211,21 @@ etcd:
service:
port: 2379
- replicaCount: 3
+ statefulset:
+ replicaCount: 3
+ persistence:
+ enabled: true
+ size: 8Gi
+ # storageClass: "-"
dashboard:
enabled: false
-
+ config:
Review comment:
@gxthrj Yeah, I'm very aware of this DRY(dont-repeat-yourself) stuff,
that's why I explained in the description above that a minimized config for
`dashboard` is necessary due to the different helm release name would cause a
potential issue, which another service name of `etcd` would make `dashboard`
failing to connect, however, I still partially agree with you as it is a
nice-to-have stuff, I'd like to take the advice from @tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
