zll2 commented on a change in pull request #4702:
URL: https://github.com/apache/apisix/pull/4702#discussion_r679087490



##########
File path: apisix/discovery/nacos.lua
##########
@@ -211,7 +272,7 @@ local function get_base_uri()
         url = url .. '/'
     end
 
-    return url, username, password
+    return url, username, password, access_key, secret_key, authorization_type

Review comment:
       这里的建议是 authorization_type 返回顺序往前提?
   
   1、username, password
   2、access_key, secret_key
   
   1 和 2 是两两组合使用,用于支持 2 种不同的认证方式




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to