spacewander commented on a change in pull request #4702:
URL: https://github.com/apache/apisix/pull/4702#discussion_r679096840
##########
File path: apisix/discovery/nacos.lua
##########
@@ -211,7 +272,7 @@ local function get_base_uri()
url = url .. '/'
end
- return url, username, password
+ return url, username, password, access_key, secret_key, authorization_type
Review comment:
There is a typo in my suggestion...
It should be
```
url, authorization_type, username, password
or
url, authorization_type, access_key, secret_key
```
It seems that each authorization_type only uses two of them, so we can
return only four values instead of six.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
