wayne-cheng commented on a change in pull request #4856:
URL: https://github.com/apache/apisix/pull/4856#discussion_r693303520



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -459,11 +459,11 @@ http {
 
     server {
         {% for _, item in ipairs(node_listen) do %}
-        listen {* item.port *} default_server {% if enable_reuseport then %} 
reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
+        listen {* item.ip *}:{* item.port *} default_server {% if 
enable_reuseport then %} reuseport {% end %};

Review comment:
       OK, and it means that the config `apisix.node_listen[]` also has the 
property `enable_http2` , right?
   ```yaml
   apisix:
     # node_listen: 9080                # APISIX listening port
     node_listen:                   # This style support multiple ports
     - 9080
     # - ip: 127.0.0.2                # Specific IP, If not set, the default 
value is `0.0.0.0`.
     #   port: 9082
     #   enable_http2: true  
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to