spacewander commented on a change in pull request #4856:
URL: https://github.com/apache/apisix/pull/4856#discussion_r693299884
##########
File path: conf/config-default.yaml
##########
@@ -113,8 +116,14 @@ apisix:
enable_resolv_search_opt: true # enable search option in resolv.conf
ssl:
enable: true
- enable_http2: true
- listen_port: 9443
+ listen:
+ - 9443
+ - ip: 127.0.0.3 # Specific IP, If not set, the default value
is `0.0.0.0`.
+ port: 9444
+ enable_http2: true # If not set, the default value is `false`.
+ #port: 9081
+ #enable_http2: true
+ #listen_port: 9443
Review comment:
I prefer to:
```yaml
apisix:
# node_listen: 9080 # APISIX listening port
node_listen: # This style support multiple ports
- 9080
# - ip: 127.0.0.2 # Specific IP, If not set, the default
value is `0.0.0.0`.
# port: 9082
ssl:
enable: true
listen: # APISIX listening port in https.
- 9443
# - ip: 127.0.0.3 # Specific IP, If not set, the default
value is `0.0.0.0`.
# port: 9444
# enable_http2: true # If not set, the default value is
`false`.
enable_http2: true # Not recommend: This parameter should
be set via the `listen`.
# listen_port: 9443 # Not recommend: This parameter should
be set via the `listen`.
```
Let's encourage users to use the new style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
