okaybase commented on a change in pull request #4863:
URL: https://github.com/apache/apisix/pull/4863#discussion_r694440978
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -205,6 +201,11 @@ function _M.log(conf, ctx)
end
end
+ if core.table.nkeys(broker_list) == 0 then
Review comment:
Currently the `broker_list` is `object` type, if redefine the type of
`broker_list` will break(e.g. `array` type), so in this case, would you give
some suggestion~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
