okaybase commented on a change in pull request #4863:
URL: https://github.com/apache/apisix/pull/4863#discussion_r695373161
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -205,6 +201,11 @@ function _M.log(conf, ctx)
end
end
+ if core.table.nkeys(broker_list) == 0 then
Review comment:
the document has been seen, and we can add `minProperties = 1`
validation to the `broker_list` schema, but this logic `if
core.table.nkeys(broker_list) == 0 then` is also required, because check `port`
type is number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
