zhendongcmss commented on a change in pull request #5292:
URL: https://github.com/apache/apisix/pull/5292#discussion_r733482814



##########
File path: apisix/plugins/proxy-rewrite.lua
##########
@@ -34,6 +34,13 @@ local schema = {
             maxLength   = 4096,
             pattern     = [[^\/.*]],
         },
+        method = {
+            description = "proxy route method",
+            type        = "string",
+            enum        = {"GET", "POST", "PUT", "HEAD", "DELETE", "OPTIONS",

Review comment:
       From curent code, parameters are rarelt used in schema, but this way 
reducing code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to