spacewander commented on a change in pull request #5292:
URL: https://github.com/apache/apisix/pull/5292#discussion_r734176942



##########
File path: t/plugin/proxy-rewrite.t
##########
@@ -1342,3 +1342,115 @@ host: test.com:6443
 x-real-ip: 127.0.0.1
 --- no_error_log
 [error]
+
+
+
+=== TEST 46: set route(rewrite method)

Review comment:
       ~~Could you add the new test in proxy-rewrite2.t? We don't need to set 
`--- no_error_log` for tests in that file.~~
   We can add the new test in proxy-rewrite3.t, with no_error_log set like 
https://github.com/apache/apisix/blob/2f250d53698b0fa617ea981d2d488ebd756bb655/t/plugin/cors2.t#L32




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to