gxthrj commented on a change in pull request #161:
URL: https://github.com/apache/apisix-helm-chart/pull/161#discussion_r737446849
##########
File path: charts/apisix/templates/deployment.yaml
##########
@@ -94,6 +103,13 @@ spec:
- configMap:
name: {{ include "apisix.fullname" . }}
name: apisix-config
+ {{- if .Values.customPlugins.enabled }}
+ {{- range $plugin := .Values.customPlugins.plugins }}
+ - name: plugin-{{ $plugin.configMap.name }}
+ configMap:
+ name: {{ $plugin.configMap.name }}
Review comment:
> put all plugins codes into the same configmap might cause the key
confictions.
I mean you can use different filed names to distinguish the configuration of
different plugins. The field name is here
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/templates/configmap.yaml#L19
This is the same as the configmap name of each plug-in, except that the name
is stored in one configmap as a key.
This has another advantage, we can write an example for users to refer to,
and will not lead to flooding due to too much configmaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
