tokers commented on a change in pull request #161:
URL: https://github.com/apache/apisix-helm-chart/pull/161#discussion_r737952387
##########
File path: charts/apisix/templates/deployment.yaml
##########
@@ -94,6 +103,13 @@ spec:
- configMap:
name: {{ include "apisix.fullname" . }}
name: apisix-config
+ {{- if .Values.customPlugins.enabled }}
+ {{- range $plugin := .Values.customPlugins.plugins }}
+ - name: plugin-{{ $plugin.configMap.name }}
+ configMap:
+ name: {{ $plugin.configMap.name }}
Review comment:
> I mean you can use different filed names to distinguish the
configuration of different plugins. The field name is here
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/templates/configmap.yaml#L19
Yes, we can decide the key name by ourselves, but then how did we decide the
mapping relationship between the key name and the actual mount path? how can
you know file should be mounted in which way, also, please know that a plugin
might have multiple files and these files may be in their own directories, the
organization of directories will affect how they import the codes in the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
