gxthrj commented on a change in pull request #742:
URL:
https://github.com/apache/apisix-ingress-controller/pull/742#discussion_r757188056
##########
File path: pkg/ingress/compare.go
##########
@@ -42,7 +43,7 @@ func (c *Controller) CompareResources(ctx context.Context)
error {
consumerMapA6 = make(map[string]string)
)
// watchingNamespace == nil means to monitor all namespaces
- if c.watchingNamespace == nil {
+ if !validation.HasValueInSyncMap(c.watchingNamespace) {
Review comment:
I think it is not necessary, because the `sync.Map` in
`HasValueInSyncMap ` is concurrency safe, which use `atomic.Value` and `Mutex`
inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
